[TypeDeclaration] Handle with other method from parent on KnownMagicClassMethodTypeRector#7423
[TypeDeclaration] Handle with other method from parent on KnownMagicClassMethodTypeRector#7423samsonasik merged 4 commits intomainfrom
Conversation
…lassMethodTypeRector
|
Fixed 🎉 /cc @TomasVotruba |
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
| "rules-tests/CodingStyle/Rector/Namespace_/ImportFullyQualifiedNamesRector/Source", | ||
| "rules-tests/Renaming/Rector/Name/RenameClassRector/Source" | ||
| "rules-tests/Renaming/Rector/Name/RenameClassRector/Source", | ||
| "rules-tests/TypeDeclaration/Rector/ClassMethod/KnownMagicClassMethodTypeRector/Source" |
There was a problem hiding this comment.
This should not be needed. The class respects PSR-4, right?
There was a problem hiding this comment.
It is weird that without it, it doesn't work on this case, probably some sort order issue or some case sensitive typo, but double check without add to classmap, use previous return null, then run "composer update", and error happen
There was a problem hiding this comment.
Ok, I got it, the class name is different with file name:
-abstract class ParentClassWithOtherMethod
+abstract class ParentClassOtherMethodas file name is named ParentClassOtherMethod, I will create new PR for it.
There was a problem hiding this comment.
I created new PR for it:
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
2 participants
Ref #7422 (review)